Fix "find all references" when using the IDE in the Dotty build #6356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running "find all references" in Dotty itself used to fail because constructing the map of project to their dependency failed, because this map is based on the `projectDependencies` key written in `.dotty-ide.json` which might contain projects which are not loaded in the IDE because they were excluded with `excludeFromIDE`. This commit fixes this by just ignoring dependencies which do not correspond to projects loaded in the IDE, this is the most resilient way to fix this.
nicolasstucki
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running "find all references" in Dotty itself used to fail because
constructing the map of project to their dependency failed, because this
map is based on the
projectDependencieskey written in.dotty-ide.jsonwhich might contain projects which are not loaded inthe IDE because they were excluded with
excludeFromIDE.This commit fixes this by just ignoring dependencies which do not
correspond to projects loaded in the IDE, this is the most resilient
way to fix this.